Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add thumbnail image for chart widget #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

denysdovhan
Copy link
Member

This needs to be merged after this: https://github.com/wix-private/wix-cli/pull/3013

Key points:

  • The PR above contains an implementation for presets
  • It also contains schema changes for presets
  • It also has fixes to @wix/gena package for properly copying binary files (images) without breaking them

Anyway, this PR needs to be checked with the latest @wix/gena and latest wix-cli/create-app.

@denysdovhan denysdovhan self-assigned this Dec 23, 2024
}
},
"presets": [{
"id": "<%= generatePageID() %>",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create-app exposes randomUUID as generatePageID for templates. It doesn't make sense in this case, since we're not generating a pageId, but we actually need a randomUUID.

There are 2 ways to fix this (from my point of view):

  1. Remove generatePageID from templates and replace it with randomUUID directly.
  2. Expose additional method (name, for example, generateUniqueID) and keep it along the generatePageID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant