Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add thumbnail image for chart widget #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add thumbnail image for chart widget #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added chart-widget/template/public/chart-widget/thumbnail.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 5 additions & 1 deletion chart-widget/template/src/site/widgets/custom-elements/chart-widget/element.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,9 @@
"installation": {
"autoAddToSite": true,
"essential": false
}
},
"presets": [{
"id": "<%= generatePageID() %>",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create-app exposes randomUUID as generatePageID for templates. It doesn't make sense in this case, since we're not generating a pageId, but we actually need a randomUUID.

There are 2 ways to fix this (from my point of view):

  1. Remove generatePageID from templates and replace it with randomUUID directly.
  2. Expose additional method (name, for example, generateUniqueID) and keep it along the generatePageID.

"thumbnailUrl": "{{PUBLIC_URL}}/chart-widget/thumbnail.png"
}]
}