Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TLS v1.2 session resumption edge cases #8097

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

julek-wolfssl
Copy link
Member

@julek-wolfssl julek-wolfssl commented Oct 22, 2024

  • Fix for TLS v1.2 session resumption with tickets where the server decides to do a full handshake. The wrong sessionIDSz was being checked and should be the arrays one since it get set from the server_hello.
  • Fixes issue with server_hello including session_id when not doing resumption.
  • Optimize entropy use. Only generate the exact amount of random data that we will actually keep.
  • Send a new session ticket when rejecting a session ticket and session tickets are enabled

Refactor done as part of work on ZD18822

@julek-wolfssl julek-wolfssl self-assigned this Oct 22, 2024
Optimize entropy use. Only generate the exact amount of random data that we will actually keep.

Refactor done as part of work on ZD18822
@julek-wolfssl
Copy link
Member Author

Retest this please

@dgarske dgarske self-requested a review October 23, 2024 17:47
@dgarske dgarske self-assigned this Oct 23, 2024
…ides to do a full handshake. The wrong sessionIDSz was being checked and should be the arrays one since it get set from the server_hello.
@dgarske dgarske changed the title Simplify TLS 1.2 session ID logic Fix TLS v1.2 session resumption edge cases Oct 23, 2024
@JacobBarthelmeh JacobBarthelmeh removed their assignment Oct 23, 2024
@douzzer douzzer merged commit e7e2053 into wolfSSL:master Oct 23, 2024
141 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants