Prevent cancelling tokens on ITN replays. #318
+20
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Detects a possible ITN request replay when updating a subscription token. If the new and old token match, the token isn't cancelled as this will result in storing a token that is no longer valid.
Replays can either triggered manually or due to network issues.
Closes https://linear.app/a8c/issue/PAYFAST-33/double-itn-request-might-cancel-valid-token
Steps to test the changes in this Pull Request:
I was unable to reproduce the issue described in the bug, this is some defensive coding.
_payfast_subscription_token
stored against the new subscription._payfast_subscription_token
meta data has updatedChangelog entry