Skip to content

Prevent cancelling tokens on ITN replays. #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Prevent cancelling tokens on ITN replays. #318

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions includes/class-wc-gateway-payfast.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,14 +707,29 @@ public function handle_itn_request( $data ) {
$subscription = wcs_get_subscription( $order_id );
if ( ! empty( $subscription ) && ! empty( $token ) ) {
$old_token = $this->_get_subscription_token( $subscription );
// Cancel old subscription token of subscription if we have it.
if ( ! empty( $old_token ) ) {

/*
* Cancel old subscription token.
*
* Cancels an old subscription token if it is defined and differs from
* the new token. The check for the same token is to account for replayed
* ITN requests as a result of an HTTP timeout or network issues returning
* the success response to the Payfast gateway.
*/
if (
! empty( $old_token )
&& $old_token !== $token
) {
$this->cancel_subscription_listener( $subscription );
}

// Set new subscription token on subscription.
$this->_set_subscription_token( $token, $subscription );
$this->log( 'Payfast token updated on Subcription: ' . $order_id );
// Set new subscription token on subscription if not an ITN replay.
if ( $old_token !== $token ) {
$this->_set_subscription_token( $token, $subscription );
$this->log( 'Payfast token updated on Subscription: ' . $order_id );
} else {
$this->log( 'Possible ITN replay detected for Payfast token update on Subscription: ' . $order_id );
}
}
}
return;
Expand Down
Loading