Disable ACDC methods during BCDC migration for legacy UI merchants (5399) #3730
+52
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description
During migration from legacy to new UI, ACDC-eligible merchants who were using BCDC need to have all ACDC card payment methods disabled to maintain proper BCDC-only state. Currently, when these merchants migrate, the BCDC override flag is set correctly but ACDC card methods may remain enabled, creating potential conflicts.
PR Description
Adds logic to explicitly disable all ACDC card payment methods during migration when ACDC-eligible merchants were using BCDC in the legacy UI, ensuring clean BCDC-only state in the new UI.
Changes:
disable_acdc_methods()
method inPaymentSettingsMigration
classPaymentMethodsDefinition
toggle_method_state(false)
is_bcdc_enabled_for_acdc_merchant()
returns trueProblem Addressed:
In the legacy UI, ACDC-eligible merchants could use BCDC (Standard Card buttons) while having other card-related methods (like Google Pay) enabled simultaneously. Without explicit cleanup during migration, these ACDC methods could remain active in the new UI, causing:
Before Migration
After