Skip to content

Disable ACDC methods during BCDC migration for legacy UI merchants (5399) #3730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Disable ACDC methods during BCDC migration for legacy UI merchants (5399) #3730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e891819
feat: disable ACDC methods during BCDC migration for legacy UI merchants
Narek13 Oct 1, 2025
27c4124
style: Fix the CS
Narek13 Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/ppcp-settings/services.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,7 @@
$c->get( 'api.helpers.dccapplies' ),
$c->get( 'wcgateway.helper.dcc-product-status' ),
$c->get( 'wcgateway.configuration.card-configuration' ),
$c->get( 'settings.data.definition.methods' ),
$c->get( 'ppcp-local-apms.payment-methods' ),
),
'settings.service.data-migration.general-settings' => static fn( ContainerInterface $c ): SettingsMigration => new SettingsMigration(
Expand Down
76 changes: 51 additions & 25 deletions modules/ppcp-settings/src/Service/Migration/PaymentSettingsMigration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
use WooCommerce\PayPalCommerce\Applepay\ApplePayGateway;
use WooCommerce\PayPalCommerce\Axo\Gateway\AxoGateway;
use WooCommerce\PayPalCommerce\Googlepay\GooglePayGateway;
use WooCommerce\PayPalCommerce\Settings\Data\Definition\PaymentMethodsDefinition;
use WooCommerce\PayPalCommerce\Settings\Data\PaymentSettings;
use WooCommerce\PayPalCommerce\WcGateway\Gateway\CreditCardGateway;
use WooCommerce\PayPalCommerce\WcGateway\Helper\CardPaymentsConfiguration;
Expand All @@ -33,6 +34,7 @@ class PaymentSettingsMigration implements SettingsMigrationInterface {
protected DccApplies $dcc_applies;
protected DCCProductStatus $dcc_status;
protected CardPaymentsConfiguration $dcc_configuration;
protected PaymentMethodsDefinition $methods_definition;

/**
* The list of local apm methods.
Expand All @@ -47,14 +49,16 @@ public function __construct(
DccApplies $dcc_applies,
DCCProductStatus $dcc_status,
CardPaymentsConfiguration $dcc_configuration,
PaymentMethodsDefinition $methods_definition,
array $local_apms
) {
$this->settings = $settings;
$this->payment_settings = $payment_settings;
$this->dcc_applies = $dcc_applies;
$this->dcc_status = $dcc_status;
$this->local_apms = $local_apms;
$this->dcc_configuration = $dcc_configuration;
$this->settings = $settings;
$this->payment_settings = $payment_settings;
$this->dcc_applies = $dcc_applies;
$this->dcc_status = $dcc_status;
$this->local_apms = $local_apms;
$this->dcc_configuration = $dcc_configuration;
$this->methods_definition = $methods_definition;
}

public function migrate(): void {
Expand All @@ -75,32 +79,18 @@ public function migrate(): void {
}
}

if ( $this->is_bcdc_enabled_for_acdc_merchant() ) {
update_option( self::OPTION_NAME_BCDC_MIGRATION_OVERRIDE, true );
}

foreach ( $this->map() as $old_key => $method_name ) {
if ( $this->settings->has( $old_key ) && $this->settings->get( $old_key ) ) {
$this->payment_settings->toggle_method_state( $method_name, true );
}
}

$this->payment_settings->save();
}
if ( $this->is_bcdc_enabled_for_acdc_merchant() ) {
$this->disable_acdc_methods();
update_option( self::OPTION_NAME_BCDC_MIGRATION_OVERRIDE, true );
}

/**
* Maps old setting keys to new payment method names.
*
* @return array<string, string>
*/
protected function map(): array {
return array(
'dcc_enabled' => CreditCardGateway::ID,
'axo_enabled' => AxoGateway::ID,
'applepay_button_enabled' => ApplePayGateway::ID,
'googlepay_button_enabled' => GooglePayGateway::ID,
'pay_later_button_enabled' => 'pay-later',
);
$this->payment_settings->save();
}

/**
Expand All @@ -126,4 +116,40 @@ public function is_bcdc_enabled_for_acdc_merchant(): bool {
$disabled_funding = $this->settings->has( 'disable_funding' ) ? $this->settings->get( 'disable_funding' ) : array();
return ! in_array( 'card', $disabled_funding, true );
}


/**
* Maps old setting keys to new payment method names.
*
* @return array<string, string>
*/
protected function map(): array {
return array(
'dcc_enabled' => CreditCardGateway::ID,
'axo_enabled' => AxoGateway::ID,
'applepay_button_enabled' => ApplePayGateway::ID,
'googlepay_button_enabled' => GooglePayGateway::ID,
'pay_later_button_enabled' => 'pay-later',
);
}

/**
* Disables all ACDC card payment methods.
*
* Iterates through all card payment methods defined in the methods definition
* and disables each one by toggling its state to false. This is used during
* migration when a merchant is switching from ACDC to BCDC classification.
*
* In the legacy UI, merchants could have certain methods (like Google Pay)
* enabled together with BCDC. During migration, we need to disable all ACDC
* card methods to ensure proper BCDC-only state in the new UI.
*
* @return void
*/
protected function disable_acdc_methods(): void {
foreach ( $this->methods_definition->group_card_methods() as $method ) {
$this->payment_settings->toggle_method_state( $method['id'], false );
$this->payment_settings->save();
}
}
}
Loading