Fail closed when VF gizmoduck author lookup is Err or missing - #149
Closed
Pitchfork-and-Torch wants to merge 2 commits into
Closed
Fail closed when VF gizmoduck author lookup is Err or missing#149Pitchfork-and-Torch wants to merge 2 commits into
Pitchfork-and-Torch wants to merge 2 commits into
Conversation
NSFW author interstitial and user-label drops only check flag presence. A failed gizmoduck read was assembled as default features, so those rules never fired and the post still ranked. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
Avoid Default on the result struct so the test compiles against the same type shape the hydrator tests already use. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
Author
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gizmoduck author Err/missing is assembled via
get_or_default.NsfwAuthorInterstitialand NSFW user-label drops only check presence, so a failed read looks unlabeled and the post ranks.Drop candidates whose author lookup is Failed or missing. Confirmed NotFound is unchanged.
FilterTweetsalready Drops omitted hydrations asunresolved_author.This is not #125 (home-mixer gizmoduck). This is not #139 (tweet safety labels). This is not #134 (TES flags).