Stop OON NSFW filter from skipping Phoenix retrieval - #185
Closed
Pitchfork-and-Torch wants to merge 1 commit into
Closed
Stop OON NSFW filter from skipping Phoenix retrieval#185Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
This was referenced Sep 8, 2026
Closed
The pre-scoring NSFW-author drop only matched ForYouSimclusters and only enabled when Simclusters was on. Phoenix, Phoenix MoE, TweetMixer, and topic retrieval of NSFW-author posts still entered RankingScorer. Drop the same OON NSFW-author posts from those retrieval sources, and enable the filter when any of them is on.
Pitchfork-and-Torch
force-pushed
the
cursor/magellan-wave2-rank-oon-nsfw-a814
branch
from
September 8, 2026 23:07
80e1bf3 to
902a06f
Compare
Author
|
Parking this intern-stack PR per operator GitHub cleanup (2026-09-08). Hunt notes remain local. Not a reject of the class. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
OONNsfwSimclustersFilteris the pre-scoring NSFW-author drop on For You OON retrieval. It only matchedForYouSimclustersand only enabled whenEnableSimclustersSourcewas on.Phoenix retrieval (
ForYouPhoenixRetrieval, including topics), Phoenix MoE, and TweetMixer use the same gizmoducknsfw_authorbit and the samein_networkstamp. NSFW-author posts from those sources still reachedPhoenixScorer/RankingScorer/TopKScoreSelector.This is not #169 (rank-all index writes). This is not #125 (gizmoduck origin size/NSFW). This is not #173 (safemodel hard-NSFW labels). In-network Thunder NSFW is unchanged.
Five-line proof
OONNsfwSimclustersFilterafterGizmoduckCandidateHydratorinPhoenixCandidatePipeline[PhoenixScorer, RankingScorer, VMRanker], thenTopKScoreSelectorserved_type == ForYouSimclusters; Phoenix / MoE / TweetMixer NSFW authors rankedChange
ForYouPhoenixRetrieval,ForYouPhoenixRetrievalMoe, andForYouTweetMixeras well as Simclustersin_network_onlyTests
in_network_only; enable on topic request when other sources are offStandalone rustc model of old vs new drop: 3/3 passed.
cargo testcannot run. Public dump has no home-mixer crate manifest.Fork PR: none