add libatomic_ops #4479
Open
add libatomic_ops #4479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
star-hengxing
requested changes
Jun 26, 2024
| add_urls("https://github.com/ivmai/libatomic_ops/releases/download/v$(version)/libatomic_ops-$(version).tar.gz", | ||
| "https://github.com/ivmai/libatomic_ops.git") | ||
|
|
||
| add_versions("7.8.2", "d305207fe207f2b3fb5cb4c019da12b44ce3fcbc593dfd5080d867b1a2419b51") |
There was a problem hiding this comment.
| on_install(function (package) | ||
| local configs = {} | ||
| table.insert(configs, "-DBUILD_SHARED_LIBS=" .. (package:config("shared") and "ON" or "OFF")) | ||
| table.insert(configs, "-DCMAKE_BUILD_TYPE=" .. (package:debug() and "Debug" or "Release")) |
There was a problem hiding this comment.
Missing windows shared lib defines.
https://github.com/ivmai/libatomic_ops/blob/cc9bc49ae39fcfdf75efb971c74393a313d70491/src/atomic_ops.h#L260
There was a problem hiding this comment.
There was a problem hiding this comment.
你可以把这个头文件拷贝下来看看，最终这个宏的值是什么，就知道为什么大部分包都要 package:add(defines
There was a problem hiding this comment.
你是指给使用者加AO_API？
There was a problem hiding this comment.
cmake 里面的宏，xmake 不能自动获取，只能包维护者手动加上。
这里我们只需要在 Windows plat 和 shared 的情况下，add defines ao_api=__declspec(dllimport) 或 ao_dll，保证函数都被 __declspec(dllimport) 修饰
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.