Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add libatomic_ops #4479
base: dev
Are you sure you want to change the base?
add libatomic_ops #4479
Changes from 1 commit
d5912d7
53a0b46
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing gpl build option
https://github.com/ivmai/libatomic_ops/blob/cc9bc49ae39fcfdf75efb971c74393a313d70491/CMakeLists.txt#L58
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing windows shared lib defines.
https://github.com/ivmai/libatomic_ops/blob/cc9bc49ae39fcfdf75efb971c74393a313d70491/src/atomic_ops.h#L260
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里指定了,不用我单独处理把?
https://github.com/ivmai/libatomic_ops/blob/cc9bc49ae39fcfdf75efb971c74393a313d70491/CMakeLists.txt#L128
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
你可以把这个头文件拷贝下来看看,最终这个宏的值是什么,就知道为什么大部分包都要 package:add(defines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
你是指给使用者加AO_API?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmake 里面的宏,xmake 不能自动获取,只能包维护者手动加上。
这里我们只需要在 Windows plat 和 shared 的情况下,add defines ao_api=__declspec(dllimport) 或 ao_dll,保证函数都被 __declspec(dllimport) 修饰