Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix example app for flutter 3.16 #190

Merged
merged 1 commit into from
Dec 1, 2023
Merged

fix: Fix example app for flutter 3.16 #190

merged 1 commit into from
Dec 1, 2023

Conversation

M-ixai-L
Copy link
Contributor

@M-ixai-L M-ixai-L commented Nov 24, 2023 •
edited by yadaniyil
Loading

Connection with issue(s)

Resolve issue

The example app does not work with the latest version of Flutter

Testing and Review Notes

The example app now works with Flutter version 3.16
Now example app use Material 3 with all flutter versions

Screenshots or Videos

Before:
Screenshot 2023-11-24 at 12 37 00

After:
Screenshot 2023-11-24 at 12 37 19

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • request the "UX" team perform a design review (if/when applicable)

@M-ixai-L M-ixai-L requested review from yadaniyil and sawel24 and removed request for yadaniyil November 24, 2023 10:38
@yadaniyil yadaniyil merged commit e93eee8 into dev Dec 1, 2023
3 of 4 checks passed
@yadaniyil yadaniyil deleted the fix/update-example-to-flutter-3.16 branch December 1, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yadaniyil yadaniyil yadaniyil approved these changes

@sawel24 sawel24 Awaiting requested review from sawel24

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@M-ixai-L @yadaniyil