Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #24 #25

Closed
wants to merge 1 commit into from
Closed

Fix #24 #25

wants to merge 1 commit into from

Conversation

vimeitor
Copy link

@vimeitor vimeitor commented Dec 7, 2017

No description provided.

@@ -140,7 +140,6 @@ endfunction
function! s:GetInput(message) " {{{
echo a:message
let ord = getchar()
normal :<c-u>
Copy link
Owner

@yangmillstheory yangmillstheory Dec 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The purpose of this line is to remove the prompts after the user has entered it a character. With this change, if you initiate a jump and cancel, the prompt remains, which is an odd user experience.

I think we need to understand the plugin's impact on the undo tree a bit more (I consciously skipped this issue before releasing, since I thought it'd be minor).

I bet operator-pending motions aren't the only places where snipe functions have unexpected side effects on it. (Relatedly, I've noticed a couple of annoying issues with the jumplist.)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, that was my impression. I don't really write viml; sorry about that. I will keep this line removed in my local copy for now, but we can close this PR if you think we can get a better solution in the future.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. I think we should focus on some more reproducible test cases on #24 before getting this going. Thanks for the submission!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants