Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #24 #25

Closed
wants to merge 1 commit into from
Closed

Fix #24 #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion autoload/snipe/core.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,6 @@ endfunction
function! s:GetInput(message) " {{{
echo a:message
let ord = getchar()
normal :<c-u>
Copy link
Owner

@yangmillstheory yangmillstheory Dec 8, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The purpose of this line is to remove the prompts after the user has entered it a character. With this change, if you initiate a jump and cancel, the prompt remains, which is an odd user experience.

I think we need to understand the plugin's impact on the undo tree a bit more (I consciously skipped this issue before releasing, since I thought it'd be minor).

I bet operator-pending motions aren't the only places where snipe functions have unexpected side effects on it. (Relatedly, I've noticed a couple of annoying issues with the jumplist.)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, that was my impression. I don't really write viml; sorry about that. I will keep this line removed in my local copy for now, but we can close this PR if you think we can get a better solution in the future.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. I think we should focus on some more reproducible test cases on #24 before getting this going. Thanks for the submission!

return ord
endfunction
" }}}
Expand Down