m7add4 added #87
Open
m7add4 added #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuma-m
reviewed
Jan 22, 2023
| @@ -54,6 +55,7 @@ | |||
| ('add11', (0, 4, 7, 17)), | |||
| ('4', (0, 4, 7, 17)), | |||
| # 5 notes | |||
| ('m7add4', (0, 3, 5, 7, 22)), # https://www.worshipchords.net/piano-chords/C/m7add4 | |||
There was a problem hiding this comment.
I think standard m7add4 is (0, 3, 5, 7, 10).
https://www.solfej.io/chords/c-m7add4
There was a problem hiding this comment.
i agree
then maybe the method names should be refined (https://arlobelshee.com/good-naming-is-a-process-not-a-single-step/) or with an extra param to clearly provide "voicing" capabilities and handle #85 and https://github.com/yuma-m/pychord/pull/84/files#r1083399429.
then all qualities should be retrieved with a %12 search in the list.
what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.