Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

m7add4 added #87

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

m7add4 added #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pychord/constants/qualities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
('maj7', (0, 4, 7, 11)),
('M7+5', (0, 4, 8, 11)),
('mM7', (0, 3, 7, 11)),
('mmaj7', (0, 3, 7, 11)), # https://jguitar.com/chordsearch/Gmmaj7
('add4', (0, 4, 5, 7)),
('Madd4', (0, 4, 5, 7)),
('madd4', (0, 3, 5, 7)),
Expand All @@ -54,6 +55,7 @@
('add11', (0, 4, 7, 17)),
('4', (0, 4, 7, 17)),
# 5 notes
('m7add4', (0, 3, 5, 7, 22)), # https://www.worshipchords.net/piano-chords/C/m7add4
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think standard m7add4 is (0, 3, 5, 7, 10).
https://www.solfej.io/chords/c-m7add4

Copy link
Contributor Author

@Moustov Moustov Jan 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree
then maybe the method names should be refined (https://arlobelshee.com/good-naming-is-a-process-not-a-single-step/) or with an extra param to clearly provide "voicing" capabilities and handle #85 and https://github.com/yuma-m/pychord/pull/84/files#r1083399429.
then all qualities should be retrieved with a %12 search in the list.
what do you think?

('m69', (0, 3, 7, 9, 14)),
('69', (0, 4, 7, 9, 14)),
('9', (0, 4, 7, 10, 14)),
Expand Down