bam/record/name: Trim trailing NUL when converting to an alignment re…

…cord name buffer

Fixes #254.

noodles-bam/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Changelog
 
+## Unreleased
+
+### Fixed
+
+  * bam/record/name: Trim trailing `NUL` when converting to an alignment record
+    name buffer ([#254]).
+
+[#254]: https://github.com/zaeleus/noodles/issues/254
+
 ## 0.59.0 - 2024-04-04
 
 ### Changed

noodles-bam/src/record/name.rs

@@ -43,7 +43,7 @@ impl<'a> fmt::Debug for Name<'a> {
 
 impl<'a> From<Name<'a>> for sam::alignment::record_buf::Name {
     fn from(name: Name<'a>) -> Self {
-        Self::from(name.as_ref())
+        Self::from(name.as_bytes())
     }
 }
 
@@ -59,4 +59,19 @@ mod tests {
         let name = Name::new(b"r0");
         assert_eq!(name.as_bytes(), b"r0");
     }
+
+    #[test]
+    fn test_from_name_for_sam_alignment_record_buf_name() {
+        use noodles_sam::alignment::record_buf::Name as NameBuf;
+
+        let expected = NameBuf::from(b"r0");
+
+        let name = Name::new(b"r0\x00");
+        let actual = NameBuf::from(name);
+        assert_eq!(actual, expected);
+
+        let name = Name::new(b"r0");
+        let actual = NameBuf::from(name);
+        assert_eq!(actual, expected);
+    }
 }