Driving timeout #128
Merged
Driving timeout #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
As mentioned in #126 (comment) this may become obsolete with #130. |
6 tasks
|
I now added a test to check if the target angle is being calculated correctly. |
|
@LukasBaecker The test is good. But I think you can revert the other changes. Can you prepare for merge soon? Would be great to have this in the 0.2.0 release... |
|
Testing this PR on a robot is not necessary anymore because the main changes have already been tested and merged in #134. This PR does only contain a test that runs in simulation. The duration of the timeout was tested on a real robot. |
This reverts commit 45dbff6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on Issue #126.