Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add default to path_2_processed arg #137

Merged
merged 6 commits into from
Aug 22, 2023
Merged

fix: add default to path_2_processed arg #137

merged 6 commits into from
Aug 22, 2023

Conversation

balajtimate
Copy link
Contributor

Description

Add None to path_2_processed: Optional[Path] as default, to prevent the validation error by Pydantic when initializing the Args class. This caused an issue during the publish docker image step of the CI.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

Please carefully read these items and tick them off if the statements are true
or do not apply.

  • I have performed a self-review of my own code
  • My code follows the existing coding style, lints and generates no new
    warnings
  • I have added type annotations to all function/method signatures, and I
    have added type annotations for any local variables that are non-trivial,
    potentially ambiguous or might otherwise benefit from explicit typing.
  • I have commented my code in hard-to-understand areas
  • I have added ["Google-style docstrings"] to all new modules, classes,
    methods/functions or updated previously existing ones
  • I have added tests that prove my fix is effective or that my feature
    works
  • New and existing unit tests pass locally with my changes and I have not
    reduced the code coverage relative to the previous state
  • I have updated any sections of the app's documentation that are affected
    by the proposed changes

If for some reason you are unable to tick off all boxes, please leave a
comment explaining the issue you are facing so that we can work on it
together.

balajtimate and others added 6 commits August 22, 2023 10:25
* test: update ci ref on docker publish

* test: update ci ref on docker publish

---------

Co-authored-by: Máté Balajti <[email protected]>
* test: update ci ref on docker publish

* test: update ci ref on docker publish

---------

Co-authored-by: Máté Balajti <[email protected]>
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (58d7bbf) 99.80% compared to head (32e11f4) 99.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #137   +/-   ##
=======================================
  Coverage   99.80%   99.80%           
=======================================
  Files          12       12           
  Lines        1039     1039           
=======================================
  Hits         1037     1037           
  Misses          2        2           
Files Changed Coverage Δ
htsinfer/models.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@balajtimate balajtimate merged commit 7d81199 into dev Aug 22, 2023
18 checks passed
@balajtimate balajtimate deleted the fix_ci branch August 22, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants