Skip to content

Conversation

@simhein
Copy link
Collaborator

@simhein simhein commented Jun 26, 2024

Add new Timers system requirements.
Remove user story from the system requirements.

Add new software timers requirements.
Regenerate the software requirements UIDs

@simhein simhein added the Requirements Requirements work label Jun 26, 2024
@simhein simhein requested review from a team and nashif June 26, 2024 18:28
@simhein simhein linked an issue Jun 27, 2024 that may be closed by this pull request
3 tasks
Copy link
Contributor

@tobiaskaestner tobiaskaestner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of comments and suggestions with the proposed changes.
There are only a couple of additional things I want to mention here>

  1. The function where the application can query the next expiry time in systicks is not covered.
  2. Do we need to specify how users can influence a timer's resolution (in ns/ms/whatever) ?
  3. For the thread syncing functionality do we need to allow for more than one thread that can synchronize with a given timer?

@simhein simhein force-pushed the timers_req branch 2 times, most recently from 7861f70 to bffab9a Compare July 9, 2024 15:13
@simhein
Copy link
Collaborator Author

simhein commented Jul 9, 2024

I left a couple of comments and suggestions with the proposed changes. There are only a couple of additional things I want to mention here>

1. The function where the application can query the next expiry time in systicks is not covered.

Added.

2. Do we need to specify how users can influence a timer's resolution (in ns/ms/whatever) ?

I think that could be specified but i don't see it here for the feature timer. because it don't give options to influence a timers resolution.

3. For the thread syncing functionality do we need to allow for more than one thread that can synchronize with a given timer?

Yes that is the way it is implemented as far as I see.

Copy link
Contributor

@tobiaskaestner tobiaskaestner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to draw attention on the point about side-effects I made eaerlier again. I think it's good that these things bubble up now and I'd love to see more people take a look at this to make sure we are not overlooking an issue that has been dormant again.

Copy link

@nicpappler nicpappler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for me when the open comments are resolved.

@simhein simhein self-assigned this Sep 2, 2024
Add new Timers system requirements.
Remove user story from the system requirements.
Update description and titels of the existing requirements to
fit better to the guidelines.

Signed-off-by: Simon Hein <[email protected]>
Add new timers requirements on the software level
Remove the user stories from the existing requirements.
Remove obsolete requirements and rephrase existing ones.

Signed-off-by: Simon Hein <[email protected]>
@dleach02
Copy link
Member

PR rebased

@parphane
Copy link
Collaborator

parphane commented May 5, 2025

3. For the thread syncing functionality do we need to allow for more than one thread that can synchronize with a given timer?

Yes that is the way it is implemented as far as I see.

"Timer thread synchronization" does not limit to 1 thread, so acceptable

parphane added a commit to parphane/reqmgmt that referenced this pull request Jun 19, 2025
Import Timer requirements from zephyrproject-rtos#75 pull request.
Fixes zephyrproject-rtos#65

Signed-off-by: Stephane Parenti <[email protected]>
@parphane parphane mentioned this pull request Jun 19, 2025
parphane added a commit that referenced this pull request Jul 29, 2025
Import Timer requirements from #75 pull request.
Fixes #65

Signed-off-by: Stephane Parenti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Requirements Requirements work

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

Timers Requirements

6 participants