MappedFile: fix the insert range path not updating the root node #25332
+50
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobly0
force-pushed
the
elfv2-fix-insert-range
branch
from
1631616 to
829ac97
Compare
|
MappedFile looks very unit-testable. just a suggestion |
Unfortunately, the repro is currently build the compiler with a ReleaseSafe compiler, I don't have a reduction. |
jacobly0
force-pushed
the
elfv2-fix-insert-range
branch
from
829ac97 to
ca4c241
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes crashes compiling the compiler with the new linker with safety enabled.
Fixes #25326