Merged
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Occasionally, when performing queries with large responses, the parser function sometimes gets stuck in an infinite loop. It appears the socket does not write only complete chunks, but will occasionally write a full chunk + plus a couple of bytes into the next chunk. usually something to the effect of
[0x30, 0x84,0x00,0x00,0x00]as you can see this is the start of a sequence using a variable length byte encoding, but is missing the 6th byte. Because of this the parser will just keep recursing with this partial sequence message until it hits the stack call limit.If we do a check to make sure the berReader has a length of 0 we just return since we know for sure there is not enough data in the buffer to proceed.
Example (pre-fix)
(post-fix)
