Skip to content

fix infinte loop in parser.parse() #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zont merged 1 commit into from
Apr 14, 2025
Merged

fix infinte loop in parser.parse() #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/responses/parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,13 @@ class Parser extends EventEmitter {
return;
}

if (ber.remain < ber.length) {
// If ber.length == 0, then we do not have a complete chunk
// and can't proceed with parsing.
// Allowing this function to continue results in an infinite loop
// and due to the recursive nature of this function quickly
// hits the stack call size limit.
// This only happens with very large responses.
if (ber.remain < ber.length || ber.length === 0) {
return;
}

Expand Down