fix(F148): background context_briefing renders as card instead of raw JSON#395
fix(F148): background context_briefing renders as card instead of raw JSON#395
Conversation
…ndler Background thread's system_info handler was missing the context_briefing branch, causing raw JSON to render as a plain system bubble instead of a BriefingCard. Mirrors the existing foreground logic in useAgentMessages. [砚砚/GPT-54🐾] [宪宪/Opus-46🐾] Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mindfn
force-pushed
the
fix/briefing-render-bg
branch
from
a9d288b to
f91933a
Compare
|
@codex review Please review latest commit f91933a for P1/P2 only. 规则：任何 P1/P2 必须给"可执行复现"：
审查标准（详见 AGENTS.md "Review guidelines" section）：
|
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review Please review latest commit 5ad135d for P1/P2 only. 规则：任何 P1/P2 必须给"可执行复现"：
审查标准（详见 AGENTS.md "Review guidelines" section）：
|
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review Please review latest commit 35b1852 for P1/P2 only. 规则：任何 P1/P2 必须给"可执行复现"：
审查标准（详见 AGENTS.md "Review guidelines" section）：
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
clowder-ai/scripts/install-auth-config.mjs
Lines 348 to 349 in 35b1852
Propagate non-corrupt homedir migration failures
The new homedir fallback swallows every error via catch {}, even though the adjacent comment says only corrupt homedir files should be ignored; this hides deterministic filesystem failures and silently skips migration. Repro (deterministic): tmp=$(mktemp -d); mkdir -p "$tmp/proj/.cat-cafe" "$tmp/home/.cat-cafe/provider-profiles.json"; HOME="$tmp/home" node scripts/install-auth-config.mjs client-auth set --project-dir "$tmp/proj" --client openai --mode oauth; echo $? (input makes provider-profiles.json a directory, so reading it raises EISDIR). Expected: non-corrupt migration failure is surfaced (non-zero exit); actual: command exits 0 and continues, so legacy homedir data is skipped without any signal.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Review triage for the reported P2 on
So this finding points to existing main-branch behavior, not a regression introduced by the |
1 participant
Summary
system_infohandler was missing thecontext_briefingbranch, causing raw JSON to render as a plain system bubble instead of a BriefingCardcontext_briefingconsumer touseSocket-background-system-info.ts, mirroring the existing foreground logic inuseAgentMessages.tsFixes #404
Test plan
pnpm exec vitest run src/hooks/__tests__/useSocket-background.test.ts -t "stores the briefing card message"— red before fix, green afterpnpm exec vitest run src/hooks/__tests__/useSocket-background.test.ts— 53/53 passCredits
🐾 Generated with Claude Code