-
Notifications
You must be signed in to change notification settings - Fork 180
fix(F148): background context_briefing renders as card instead of raw JSON #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mindfn
wants to merge
8
commits into
main
Choose a base branch
from
fix/briefing-render-bg
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+105
−0
Open
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f91933a
fix(F148): add context_briefing consumer to background system-info ha…
mindfn 50fc1de
Merge branch 'main' into fix/briefing-render-bg
mindfn 5ad135d
fix: format project setup IME test [砚砚/GPT-5.4🐾]
mindfn 35b1852
Merge branch 'main' into fix/briefing-render-bg
mindfn ac0e72b
Merge branch 'main' into fix/briefing-render-bg
mindfn a604b6f
Merge branch 'main' into fix/briefing-render-bg
mindfn 6d55072
Merge branch 'main' into fix/briefing-render-bg
mindfn c2ea740
fix: preserve fallback for incomplete briefing payload [砚砚/GPT-5.4🐾]
mindfn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This branch marks
context_briefingas consumed even when no message was actually inserted (for example, ifstoredMessageexists butidis missing/invalid). In that case the background thread drops the event entirely instead of falling back to the existing raw system bubble path, so users get no visible signal and debugging becomes harder. Only settingconsumed = trueafter a successfuladdMessageToThreadwould keep the previous fail-open behavior.Useful? React with 👍 / 👎.