Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template-based smartSPIM-CCF registration #19

Conversation

Di-Wang-AIND
Copy link
Collaborator

Add template-based smartSPIM-CCF registration

@camilolaiton
Copy link
Collaborator

@Di-Wang-AIND, antspyx latests version is 0.4.2 and oldest published in pypi is 0.3.8. I recommend you change the version to the latest and check all the registration process again to make sure it is compatible.

Copy link
Collaborator

@camilolaiton camilolaiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lastly, please run black isort interrogate and flake8 linters to make sure the code is compatible with all aind-python standards. Thanks!

code/aind_ccf_reg/configs.py Outdated Show resolved Hide resolved
code/aind_ccf_reg/plots.py Outdated Show resolved Hide resolved
code/aind_ccf_reg/preprocess.py Outdated Show resolved Hide resolved
code/aind_ccf_reg/preprocess.py Show resolved Hide resolved
code/aind_ccf_reg/preprocess.py Show resolved Hide resolved
code/aind_ccf_reg/preprocess.py Show resolved Hide resolved
code/aind_ccf_reg/preprocess.py Outdated Show resolved Hide resolved
code/aind_ccf_reg/preprocess.py Outdated Show resolved Hide resolved
code/aind_ccf_reg/register.py Show resolved Hide resolved
Copy link
Collaborator

@camilolaiton camilolaiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, still some docs missing and unit tests.

@Di-Wang-AIND Di-Wang-AIND marked this pull request as ready for review June 5, 2024 02:05
Copy link
Collaborator

@camilolaiton camilolaiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Di is on vacations, I'll be taking over these updates to deploy it on the pipeline.

@camilolaiton camilolaiton changed the base branch from main to feat-template-reg June 12, 2024 16:12
@camilolaiton camilolaiton merged commit 15dccf4 into AllenNeuralDynamics:feat-template-reg Jun 12, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants