-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template-based smartSPIM-CCF registration #19
Template-based smartSPIM-CCF registration #19
Conversation
…aind-ccf-registration into template-based-reg
@Di-Wang-AIND, antspyx latests version is 0.4.2 and oldest published in pypi is 0.3.8. I recommend you change the version to the latest and check all the registration process again to make sure it is compatible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lastly, please run black isort interrogate and flake8 linters to make sure the code is compatible with all aind-python standards. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, still some docs missing and unit tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Di is on vacations, I'll be taking over these updates to deploy it on the pipeline.
15dccf4
into
AllenNeuralDynamics:feat-template-reg
Add template-based smartSPIM-CCF registration