AP_Logger: File: clean up fsync code #29308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now FATFS will always sync on 4K boundaries even if it gets misaligned due to a short or forced write. LittleFS behavior is verified identical.
peterbarker
reviewed
Feb 16, 2025
tridge
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
looks good to me!
@peterbarker you OK with this as logging maintainer?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for details.
Costs <200 bytes on ChibiOS in general but simplifies the code and allows for further cleanup. I intend to come back and do this as well, I think some of these assumptions are outdated.
Tested on Cube Orange and KakuteH7Mini-Nand. Log behavior and performance is identical before and after.