Implementing deaths #46
Draft
erik-rosenstrom wants to merge 4 commits intomainfrom
Draft
Conversation
fbec31c to
17f60e5
Compare
b5b96eb to
6394ecd
Compare
6394ecd to
c0f9685
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the effects of a dead symptom status. This involves disallowing future plans that are scheduled to happen for dead individuals and removing them from setting membership.
Changes
aliveperson property is set to false, they are removed from setting membership, and if they are infectious when they die, the directly transition to the recovered infection status.add_plancalledadd_plan_if_alivethat checks if the person is alive before executing the callback.infection_managerandinfection_propagation_loopmodules to check if the person is alive before proceedingOpen Question
Should the
add_plan_if_alivebe used for all plans? Even those in the symptom status manager that execute before a person dies?Additional Resource
A design document for deaths in models can be found here