ButtonPanel #21
Open
ButtonPanel #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryankarpuszka
requested changes
Oct 30, 2020
| from tkinter import* | ||
|
|
||
| # creating button for autonomous mapping | ||
| window = Tk() |
There was a problem hiding this comment.
You can put all of this code under one method called run(stream) so that other code can call it.
| lbl = Label(window, text = "Autonomous Mapping", bg = 'red', fg ='white') | ||
| lbl.grid(column=0, row=0) | ||
| def clicked(): | ||
| lbl.configure(text="Autonomous Mapping (Clicked)") |
There was a problem hiding this comment.
I think it would be best to keep the label text the same. For now you can replace these methods with pass which will tell python to do nothing when it runs the method. Once the other code gets merged in, you can call it from here.
| window.geometry('300x300') | ||
| window.configure(width =50,height = 50, bg='blue') | ||
|
|
||
| lbl = Label(window, text = "Autonomous Mapping", bg = 'red', fg ='white') |
There was a problem hiding this comment.
The code here is a bit repetitive, so it's a good practice to create a helper method like add_button that will handle adding the label and button for you. Then you could just keep calling that method to create all the buttons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
// this is for the buttons panel
// shows you the different visions taks