Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDAP authentication option #132

Open
martinjrobins opened this issue Sep 2, 2024 · 4 comments · May be fixed by #134
Open

LDAP authentication option #132

martinjrobins opened this issue Sep 2, 2024 · 4 comments · May be fixed by #134
Labels
enhancement New feature or request

Comments

@martinjrobins
Copy link
Collaborator

martinjrobins commented Sep 2, 2024

@mirams, I would like to add an LDAP authentication option for login. This would:

  • Add option to deactivate existing user registration
  • Add option to enable authentication via an LDAP server
  • Authenticate users via LDAP based on user groups (admin or user)
  • Use environment variables to control authentication options and supply ldap urls + search strings

I would propose to use the django-auth-ldap library to do this (I've used this before for https://github.com/pkpdapp-team/pkpdapp), which would be added as a dependency

Motivation: To enable a deployment of ap-nimbus within the Roche authentiation system

@mirams
Copy link
Member

mirams commented Sep 2, 2024

This sounds good to me, would welcome a pull request (plus any sensible tests you can think of for it). @kwabenantim is mainly looking after this at the moment, any thoughts @kwabenantim?

@mirams mirams added the enhancement New feature or request label Sep 2, 2024
@kwabenantim
Copy link
Member

That sounds like a useful feature to me as well.

@martinjrobins
Copy link
Collaborator Author

Great :) I’ll get started on this and submit a pr when finished

martinjrobins added a commit to martinjrobins/ap-nimbus-client that referenced this issue Sep 10, 2024
@martinjrobins
Copy link
Collaborator Author

update on this, I have an implementation which I think should work, but am blocked at the moment as I can't access the servers I need to test it. Once my access is restored I'll test this and then make a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants