-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ldap authentication #134
base: master
Are you sure you want to change the base?
ldap authentication #134
Conversation
sorry the autoformatter (black) made this PR a bit noisy :( there a quite a few lines in the ldap settings file that are not covered. I'm not sure how to test these without making an ldap server part of the CI. But I have tested it against an internal LDAP server and everything is working ok |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #134 +/- ##
==========================================
- Coverage 99.60% 97.60% -2.00%
==========================================
Files 30 30
Lines 1503 1543 +40
Branches 244 252 +8
==========================================
+ Hits 1497 1506 +9
- Misses 6 36 +30
- Partials 0 1 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks @martinjrobins. It looks good to me. I'll try it out locally and look at some options for mock testing ldap on github actions. |
Hi @kwabenantim, have you had a chance to try this out? Let me know if there are any changes you would like me to make |
I'll try to finish this today @martinjrobins! |
note, could use this for testing: https://pypi.org/project/fakeldap/ |
Fixes #132
This adds an option to authenticate via a ldap server, with logging in users as either normal users or admin depending on the ldap groups they are assigned to. This feature is controlled by a number of environment variables, which I've added to the example env file with some comments
It also adds some other quality-of-life stuff that I found useful, let me know if this is what you want: