-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add thirty models #13
base: master
Are you sure you want to change the base?
Conversation
…tch to draw_graph
…arkov-builder into fix_transition_matrix
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
==========================================
+ Coverage 89.71% 93.30% +3.59%
==========================================
Files 5 22 +17
Lines 554 837 +283
==========================================
+ Hits 497 781 +284
+ Misses 57 56 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Add sundials install to workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Joey,
Won't have time for an in-depth review (if you want that) till June or after.
Few small comments. And comparison 2 looks plain wrong?
Would plot an error for these 3 cases too (signal1 - signal2)
…arkov-builder into fix_transition_matrix
Description
Add models 1-11 and 30 from CardiacModelling/hergModels/tree/master/models_myokit. These models are tested by comparing Myokit Simulation output form the original .mmt files with those generated through the Markov_builder.
The newly added models make extensive use of the shared_variables_dict. The behaviour of parameterise_rates was modified to make it more convenient to set these variables to numerical values.
These changes exposed some issues with reversibility checking and transition matrix calculation which have now been fixed.
The new models can be easily generated by users and modified to include drug-trapping or additional states/parameters.
Types of changes
Testing
Documentation checklist