Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thirty models #13

Draft
wants to merge 30 commits into
base: master
Choose a base branch
from
Draft

Add thirty models #13

wants to merge 30 commits into from

Conversation

joeyshuttleworth
Copy link
Collaborator

@joeyshuttleworth joeyshuttleworth commented Apr 28, 2023

Description

Add models 1-11 and 30 from CardiacModelling/hergModels/tree/master/models_myokit. These models are tested by comparing Myokit Simulation output form the original .mmt files with those generated through the Markov_builder.

The newly added models make extensive use of the shared_variables_dict. The behaviour of parameterise_rates was modified to make it more convenient to set these variables to numerical values.

These changes exposed some issues with reversibility checking and transition matrix calculation which have now been fixed.

The new models can be easily generated by users and modified to include drug-trapping or additional states/parameters.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

Documentation checklist

  • I have updated all documentation in the code where necessary.
  • I have checked spelling in all (new) comments and documentation.
  • I have added a note to RELEASE.md if relevant (new feature, breaking change, or notable bug fix).

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #13 (93b454f) into master (5672637) will increase coverage by 3.59%.
The diff coverage is 97.91%.

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
+ Coverage   89.71%   93.30%   +3.59%     
==========================================
  Files           5       22      +17     
  Lines         554      837     +283     
==========================================
+ Hits          497      781     +284     
+ Misses         57       56       -1     
Impacted Files Coverage Δ
markov_builder/MarkovChain.py 88.37% <92.04%> (+1.24%) ⬆️
markov_builder/example_models.py 98.95% <100.00%> (ø)
markov_builder/models/thirty_models/__init__.py 100.00% <100.00%> (ø)
markov_builder/models/thirty_models/model0.py 100.00% <100.00%> (ø)
markov_builder/models/thirty_models/model1.py 100.00% <100.00%> (ø)
markov_builder/models/thirty_models/model10.py 100.00% <100.00%> (ø)
markov_builder/models/thirty_models/model11.py 100.00% <100.00%> (ø)
markov_builder/models/thirty_models/model12.py 100.00% <100.00%> (ø)
markov_builder/models/thirty_models/model13.py 100.00% <100.00%> (ø)
markov_builder/models/thirty_models/model14.py 100.00% <100.00%> (ø)
... and 9 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@MichaelClerx MichaelClerx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Joey,
Won't have time for an in-depth review (if you want that) till June or after.
Few small comments. And comparison 2 looks plain wrong?
Would plot an error for these 3 cases too (signal1 - signal2)

markov_builder/MarkovChain.py Show resolved Hide resolved
markov_builder/MarkovChain.py Outdated Show resolved Hide resolved
markov_builder/MarkovChain.py Outdated Show resolved Hide resolved
@joeyshuttleworth joeyshuttleworth changed the title Fix transition matrix Add thirty models Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants