Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tc_build: llvm: Move use of build_targets out of ninja_cmd #251

Merged
merged 1 commit into from
Nov 8, 2023
Merged

tc_build: llvm: Move use of build_targets out of ninja_cmd #251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tc_build/llvm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,12 +143,12 @@ def build(self):
raise RuntimeError('BOLT requested without a builder?')

build_start = time.time()
ninja_cmd = ['ninja', '-C', self.folders.build, *self.build_targets]
self.run_cmd(ninja_cmd)
base_ninja_cmd = ['ninja', '-C', self.folders.build]
self.run_cmd([*base_ninja_cmd, *self.build_targets])

if self.check_targets:
check_targets = [f"check-{target}" for target in self.check_targets]
self.run_cmd([*ninja_cmd, *check_targets])
self.run_cmd([*base_ninja_cmd, *check_targets])

tc_build.utils.print_info(f"Build duration: {tc_build.utils.get_duration(build_start)}")

Expand All @@ -160,7 +160,7 @@ def build(self):
install_targets = [f"install-{target}" for target in self.install_targets]
else:
install_targets = ['install']
self.run_cmd([*ninja_cmd, *install_targets], capture_output=True)
self.run_cmd([*base_ninja_cmd, *install_targets], capture_output=True)
tc_build.utils.create_gitignore(self.folders.install)

def can_use_perf(self):
Expand Down