Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jupyterlab from v3 to v4 #103

Merged
merged 15 commits into from
Jan 23, 2024
Merged

Bump jupyterlab from v3 to v4 #103

merged 15 commits into from
Jan 23, 2024

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Jan 4, 2024

Bump jupyterlab from 3.6.6 to 4.0.10. See changelog at https://jupyterlab.readthedocs.io/en/4.0.x/getting_started/changelog.html

Also needed to upgrade some jupyter extensions and dependencies to newer versions that support JupyterLab 4.x:

  • jupyter-resource-usage from 0.7.1 to 1.0.1
  • jupyterlab-geojson from 3.3.1 to 3.4.0
  • jupyterlab-git from 0.41.0 to 0.50.0
  • jupyterlab-myst from 1.1.0 to 2.1.0
  • nbdime from 3.1.1 to 4.0.1
  • geemap from 0.24.4 to 0.30.0
  • dask from 2022.11.0 to 2023.12.1
  • jupytext from 1.14.1 to 1.16.1

Other possibly not so needed changes:

  • ipykernel from 6.16.0 to 6.29.0 (not pinned anymore)
  • ipython 8.6.0 to 8.20.0
  • ipywidgets 7.7.2 to 8.1.1
  • plotly from 5.11.0 to 5.18.0

Addresses #102, xref #86 (comment), closes #74

Bumps [jupyterlab](https://github.com/jupyterlab/jupyterlab) from 3.6.6 to 4.0.10.
- [Release notes](https://github.com/jupyterlab/jupyterlab/releases)
- [Changelog](https://github.com/jupyterlab/jupyterlab/blob/main/CHANGELOG.md)
- [Commits](jupyterlab/jupyterlab@v3.6.6...v4.0.10)

Also bumped jupyterlab-myst from 1.1.0 to 2.1.0, geemap from 0.24.4 to 0.30.0, and dask from 2022.11.0 to 2023.12.1.
@weiji14 weiji14 self-assigned this Jan 4, 2024
Copy link

github-actions bot commented Jan 4, 2024

Binder 👈 Test this PR on Binder

@weiji14
Copy link
Member Author

weiji14 commented Jan 4, 2024

/condalock

@weiji14
Copy link
Member Author

weiji14 commented Jan 9, 2024

/condalock

@weiji14
Copy link
Member Author

weiji14 commented Jan 10, 2024

Since this is a big-ish change, it would be good if someone can test this out properly, either using the Binder link above (if it builds ok), locally, or some staging server (if we have one)? Specifically, check that the JupyterLab extensions listed above work ok, and interactive things like GEE or the Dask Dashboards work fine.

@weiji14 weiji14 marked this pull request as ready for review January 11, 2024 04:45
@@ -36,13 +36,13 @@ dependencies:

- ipywidgets==7.7.2
- jupyterlab-favorites==3.1.0
Copy link
Member Author

@weiji14 weiji14 Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this jupyterlab-favourites extension has not been maintained since Nov 2021 as mentioned in #86 (comment), and it doesn't work in JupyterLab 4, so we should probably remove it?

Suggested change
- jupyterlab-favorites==3.1.0

@weiji14
Copy link
Member Author

weiji14 commented Jan 22, 2024

/condalock

@weiji14
Copy link
Member Author

weiji14 commented Jan 22, 2024

/condalock

@weiji14
Copy link
Member Author

weiji14 commented Jan 22, 2024

/condalock

@weiji14
Copy link
Member Author

weiji14 commented Jan 23, 2024

/condalock

- jupyter-book~=0.15.1
- jupytext==1.14.1
- jupytext~=1.16.1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was getting an 'Unhandled error' when trying to create a new notebook, and Unexpected error while saving file: example.ipynb 'coroutine' object is not subscriptable when saving notebooks in JupyterLab. Might be a case of mwouts/jupytext#1020.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, it finally worked!

Peek 2024-01-23 15-26

@weiji14 weiji14 requested a review from tsnow03 January 23, 2024 03:00
@tsnow03 tsnow03 merged commit a8f6289 into main Jan 23, 2024
1 check passed
@tsnow03 tsnow03 deleted the jupyterlab-4.0 branch January 23, 2024 07:11
@tsnow03
Copy link
Member

tsnow03 commented Jan 23, 2024

Great work @weiji14! We have a functioning JupyterLab 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants