-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/new layout #12966
base: main
Are you sure you want to change the base?
Feat/new layout #12966
Changes from all commits
28ed06f
6df8812
18a4519
527c62c
6929b1a
089194b
7283bb0
1071968
066dc1c
f4684c6
b7e7351
30fde2a
807f0c2
bd7913a
103a84e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am bit confused why this was counted as tvl in the first place, but changing folder names breaks our server There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We want to show Total BTC staked to mint stBTC and stBTC supply on BNB. There are two parts. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
const { sumTokensExport } = require("../helper/sumTokens"); | ||
const bitcoinAddressBook = require('../helper/bitcoin-book/index.js') | ||
|
||
module.exports = { | ||
methodology: "Lorenzo, As the Bitcoin Liquidity Finance Layer", | ||
doublecounted:true, | ||
bitcoin: { tvl: sumTokensExport({ owners : bitcoinAddressBook.lorenzo }) } | ||
}; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,10 @@ | ||
const { sumTokensExport } = require("../helper/sumTokens"); | ||
const bitcoinAddressBook = require('../helper/bitcoin-book/index.js') | ||
|
||
// Lorenzo Protocol Tota TVL | ||
const allBtcAddressList = [...bitcoinAddressBook.lorenzo, ...bitcoinAddressBook.lorenzo2] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no, this leads to doublecounting, as we have already listed stbtc & enzoBTC part. This merged listing is redundant imo, we already show a parent protocol that includes all sub protocols There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you change the sub protocol tab to Lorenzo stBTC, Lorenzo stBTC from BNB, Lorenzo enzoBTC? |
||
module.exports = { | ||
methodology: "Lorenzo, As the Bitcoin Liquidity Finance Layer", | ||
doublecounted:true, | ||
bitcoin: { tvl: sumTokensExport({ owners : bitcoinAddressBook.lorenzo }) } | ||
bitcoin: { tvl: sumTokensExport({ owners : allBtcAddressList }) } | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change is good, thanks