Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more Syndicate Uniforms to the Emagged Uniform Printer #2538

Merged
merged 7 commits into from
Dec 28, 2024

Conversation

Smugman
Copy link
Contributor

@Smugman Smugman commented Dec 27, 2024

About the PR

First PR Time.

Ive Added the Delta-V syndicate uniforms to the Emagged uniform printer.
Specifically: the Cybersun Lawyer Jumpsuit, the Interdyne Jumpsuit, Chemsuit and Gas mask, and the Cybersun Surgeon Jumpsuit, Surgical Cap and Windbreaker.

Ive also already added the recipes for PR#2285's Additional items, but have commented them out until it is merged, to be uncommented after testing that they actually work

Why / Balance

Why? The Upstream Uniform printer lets you print every syndicate uniform they have, Parity with DeltaVs new ones makes sense.

Now, This does allow people to print the Windbreaker, which has a 5% dmg resistance to pierce, slash, blunt and 20% Heat
and the Chemsuit which has 60% Caustic Armor with a very Civilian machine, I personally think that there are far more powerful things one can do with an EMAG and that these vanity items pale in comparrison.

In addition, this PR also allows the uniform printer to create the Interdyne gasmask, which is not only a bit unfitting for a uniform printer, but also currently the only method i know of to make gas masks.

I did not wish to split up the uniforms into different machines or leave them incomplete, so i think this is fine considering the Price of Admission (an EMAG, plus stealing or Making a Uniprinter)

Technical details

YML Changes only, modified two Upstream files, but i believe ive commented them appropriately, recipes for items that dont exist yet commented out.

Media

image

How to Test

  • Emag a Uniform Printer
  • Print Some Valids

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

N/A

Changelog
🆑

  • add: Added more recipes to the Emagged Uniform Printer, print those valids!

@Smugman Smugman requested a review from a team as a code owner December 27, 2024 04:57
@github-actions github-actions bot added size/M 64-255 lines S: Needs Review Changes: YML Changes any yml files and removed S: Needs Review labels Dec 27, 2024
@Lyndomen
Copy link
Contributor

Howdy! We are taking this under for direction review, expect a response in 24 hours. Looks good at first glance!

Lyndomen
Lyndomen previously approved these changes Dec 28, 2024
Copy link
Contributor

@Lyndomen Lyndomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Direction approved!

Signed-off-by: deltanedas <[email protected]>
@deltanedas deltanedas enabled auto-merge (squash) December 28, 2024 14:28
@deltanedas deltanedas merged commit c18f528 into DeltaV-Station:master Dec 28, 2024
14 checks passed
@Smugman Smugman deleted the ValidPrinter branch December 28, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files S: Needs Review size/M 64-255 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants