Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to copier #378

Closed
DominicOram opened this issue Mar 13, 2024 · 2 comments · Fixed by #667
Closed

Move to copier #378

DominicOram opened this issue Mar 13, 2024 · 2 comments · Fixed by #667
Assignees
@rtuck99

Comments

@DominicOram
Copy link
Contributor

We should move to the new copier template rather than the old skeleton. https://github.com/DiamondLightSource/python-copier-template is the template, https://diamondlightsource.github.io/python-copier-template/main/tutorials/adopt-existing.html is some instructions

Acceptance Criteria

  • We have moved to the copier template
  • All CI behaviour is maintained
This was referenced Mar 13, 2024
Closed
Closed
Closed
Closed
Merged
Closed
@DominicOram DominicOram mentioned this issue Apr 3, 2024
Closed
@joeshannon
Copy link
Contributor

I might have some time to take a look at this - I have some experience as I previously converted blueapi.

Probably the most fiddly part was probably moving from the separate "developer" and "user" guides to a single manual. Is that the plan for dodal too?

@DominicOram
Copy link
Contributor Author

Yep, we can combine the docs too

@rtuck99 rtuck99 self-assigned this Jul 3, 2024
@stan-dot stan-dot mentioned this issue Jul 9, 2024
Closed
rtuck99 added a commit that referenced this issue Jul 10, 2024
@rtuck99
(#378) Initial changes for copier template v1.0.0
356ec8e
rtuck99 added a commit that referenced this issue Jul 10, 2024
@rtuck99
(#378) More sensible pre-commit defaults. Fix some broken unit tests
6ae605e
rtuck99 added a commit that referenced this issue Jul 10, 2024
@rtuck99
(#378) unit tests mostly working
2b974c2
rtuck99 added a commit that referenced this issue Jul 10, 2024
@rtuck99
(#378) Update to version v2.1.0 of copier template from v1.0.0
261dbb4
rtuck99 added a commit that referenced this issue Jul 10, 2024
@rtuck99
(#378) minor fixes to documentation generation
1cf4df4
@rtuck99 rtuck99 mentioned this issue Jul 10, 2024
Merged
4 tasks
rtuck99 added a commit that referenced this issue Jul 11, 2024
@rtuck99
(#378) Enable pypi publishing
cc26920
rtuck99 added a commit that referenced this issue Jul 11, 2024
@rtuck99
(#378) Update software catalog info
a13bbe1
rtuck99 added a commit that referenced this issue Jul 11, 2024
@rtuck99
(#378) Initial changes for copier template v1.0.0
71ef7f7
rtuck99 added a commit that referenced this issue Jul 11, 2024
@rtuck99
(#378) More sensible pre-commit defaults. Fix some broken unit tests
3546761
rtuck99 added a commit that referenced this issue Jul 11, 2024
@rtuck99
(#378) unit tests mostly working
523a98f
rtuck99 added a commit that referenced this issue Jul 11, 2024
@rtuck99
(#378) Update to version v2.1.0 of copier template from v1.0.0
c8c9f66
rtuck99 added a commit that referenced this issue Jul 11, 2024
@rtuck99
(#378) minor fixes to documentation generation
efb9079
rtuck99 added a commit that referenced this issue Jul 11, 2024
@rtuck99
(#378) Enable pypi publishing
dbf0a9c
rtuck99 added a commit that referenced this issue Jul 11, 2024
@rtuck99
(#378) Update software catalog info
20e8bed
rtuck99 added a commit that referenced this issue Jul 11, 2024
@rtuck99
(#378) Rebase onto latest main
dfe4e6a
@rtuck99 rtuck99 mentioned this issue Jul 11, 2024
Closed
rtuck99 added a commit that referenced this issue Jul 11, 2024
@rtuck99
(#378) Use diff-quality rather than pyright, make pyright, ruff happy
aed1f34
rtuck99 added a commit that referenced this issue Jul 11, 2024
@rtuck99
(#378) Make ruff happy, and code less evil. Add diff-cover to depende…
ae36a04 
…ncies
rtuck99 added a commit that referenced this issue Jul 11, 2024
@rtuck99
(#378) Fix test failures due to missing decorator parentheses. Add mi…
546ab33 
…ssing pyright plugin to dependencies
rtuck99 added a commit that referenced this issue Jul 11, 2024
@rtuck99
(#378) Set fetch-depth to 0 for diff-quality
e786220
rtuck99 added a commit that referenced this issue Jul 11, 2024
@rtuck99
(#378) Fix dist CI
7cb0857
rtuck99 added a commit that referenced this issue Jul 23, 2024
@rtuck99
(#378) Initial changes for copier template v1.0.0
4a2c419
rtuck99 added a commit that referenced this issue Jul 23, 2024
@rtuck99
(#378) More sensible pre-commit defaults. Fix some broken unit tests
505c9b3
rtuck99 added a commit that referenced this issue Jul 23, 2024
@rtuck99
(#378) unit tests mostly working
f4093c3
rtuck99 added a commit that referenced this issue Jul 23, 2024
@rtuck99
(#378) Update to version v2.1.0 of copier template from v1.0.0
22643c4
rtuck99 added a commit that referenced this issue Jul 23, 2024
@rtuck99
(#378) minor fixes to documentation generation
7d8f50a
rtuck99 added a commit that referenced this issue Jul 23, 2024
@rtuck99
(#378) Enable pypi publishing
7e3a57c
rtuck99 added a commit that referenced this issue Jul 23, 2024
@rtuck99
(#378) Update software catalog info
3bf9f13
rtuck99 added a commit that referenced this issue Jul 23, 2024
@rtuck99
(#378) Rebase onto latest main
2a8925c
rtuck99 added a commit that referenced this issue Jul 23, 2024
@rtuck99
(#378) Use diff-quality rather than pyright, make pyright, ruff happy
e962560
rtuck99 added a commit that referenced this issue Jul 23, 2024
@rtuck99
(#378) Make ruff happy, and code less evil. Add diff-cover to depende…
e0b2c14 
…ncies
rtuck99 added a commit that referenced this issue Jul 23, 2024
@rtuck99
(#378) Fix test failures due to missing decorator parentheses. Add mi…
86c12fa 
…ssing pyright plugin to dependencies
rtuck99 added a commit that referenced this issue Jul 23, 2024
@rtuck99
(#378) Set fetch-depth to 0 for diff-quality
de94018
rtuck99 added a commit that referenced this issue Jul 23, 2024
@rtuck99
(#378) Fix dist CI
cb88163
rtuck99 added a commit that referenced this issue Jul 23, 2024
@rtuck99
(#378) fix tests, ruff after rebase against main
8066200
rtuck99 added a commit that referenced this issue Jul 23, 2024
@rtuck99
(#378) Add warning suppression to unit tests for pydantic v2
473765a
rtuck99 added a commit that referenced this issue Jul 23, 2024
@rtuck99
378 Convert source tree to python-copier-template (#667)
025efb0 
* (#378) Initial changes for copier template v1.0.0

* (#378) More sensible pre-commit defaults. Fix some broken unit tests

* (#378) unit tests mostly working

* Add Pycharm project files to .gitignore

* (#378) Update to version v2.1.0 of copier template from v1.0.0

* (#378) minor fixes to documentation generation

* (#378) Enable pypi publishing

* (#378) Update software catalog info

* (#378) Rebase onto latest main

* (#378) Use diff-quality rather than pyright, make pyright, ruff happy

* (#378) Make ruff happy, and code less evil. Add diff-cover to dependencies

* (#378) Fix test failures due to missing decorator parentheses. Add missing pyright plugin to dependencies

* (#378) Set fetch-depth to 0 for diff-quality

* (#378) Fix dist CI

* (#378) fix tests, ruff after rebase against main

* (#378) Add warning suppression to unit tests for pydantic v2
stan-dot pushed a commit that referenced this issue Jul 24, 2024
@rtuck99 @stan-dot
378 Convert source tree to python-copier-template (#667)
bd31082 
* (#378) Initial changes for copier template v1.0.0

* (#378) More sensible pre-commit defaults. Fix some broken unit tests

* (#378) unit tests mostly working

* Add Pycharm project files to .gitignore

* (#378) Update to version v2.1.0 of copier template from v1.0.0

* (#378) minor fixes to documentation generation

* (#378) Enable pypi publishing

* (#378) Update software catalog info

* (#378) Rebase onto latest main

* (#378) Use diff-quality rather than pyright, make pyright, ruff happy

* (#378) Make ruff happy, and code less evil. Add diff-cover to dependencies

* (#378) Fix test failures due to missing decorator parentheses. Add missing pyright plugin to dependencies

* (#378) Set fetch-depth to 0 for diff-quality

* (#378) Fix dist CI

* (#378) fix tests, ruff after rebase against main

* (#378) Add warning suppression to unit tests for pydantic v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtuck99 rtuck99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

378 Convert source tree to python-copier-template DiamondLightSource/dodal
3 participants
@rtuck99 @DominicOram @joeshannon