Use flexible preloading for oauth image by lukaskratzel · Pull Request #85 · EduIDE/EduIDE-deployment

lukaskratzel · 2026-03-23T12:16:17Z

Summary by CodeRabbit

New Features
- Added preloaded images for Java (java-17-no-ls), Rust (rust-no-ls) and language servers to improve environment startup and tooling availability; added oauth2-proxy pinned to v7.12.0 (with args ["--version"]) for consistent auth behavior.
Chores
- Updated deployment values and inline documentation to clarify image ordering and version override behavior.

coderabbitai · 2026-03-23T12:18:21Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: db6ba0b8-1f7e-49fc-843e-eb2254d7c1d8

📥 Commits

Reviewing files that changed from the base of the PR and between a2bcfdc and c849426.

📒 Files selected for processing (7)

.github/workflows/deploy-theia.yml
charts/theia-cloud-combined/values.yaml
deployments/test1.theia-test.artemis.cit.tum.de/values.yaml
deployments/test2.theia-test.artemis.cit.tum.de/values.yaml
deployments/test3.theia-test.artemis.cit.tum.de/values.yaml
deployments/theia-staging.artemis.cit.tum.de/values.yaml
deployments/theia.artemis.cit.tum.de/values.yaml

✅ Files skipped from review due to trivial changes (1)

.github/workflows/deploy-theia.yml

🚧 Files skipped from review as they are similar to previous changes (4)

deployments/test1.theia-test.artemis.cit.tum.de/values.yaml
charts/theia-cloud-combined/values.yaml
deployments/theia.artemis.cit.tum.de/values.yaml
deployments/test2.theia-test.artemis.cit.tum.de/values.yaml

📝 Walkthrough

Walkthrough

Added several Theia-related preloading images (Java/Rust variants and language servers) across Helm values files and charts, and appended an explicit oauth2-proxy:v7.12.0 preload entry with args: ["--version"]. Updated comments documenting required index alignment with workflow overrides.

Changes

Cohort / File(s)	Summary
Helm values — deployments `deployments/theia.artemis.cit.tum.de/values.yaml`, `deployments/theia-staging.artemis.cit.tum.de/values.yaml`, `deployments/test1.theia-test.artemis.cit.tum.de/values.yaml`, `deployments/test2.theia-test.artemis.cit.tum.de/values.yaml`, `deployments/test3.theia-test.artemis.cit.tum.de/values.yaml`	Appended new `theia-cloud.preloading.images` entries: `ghcr.io/eduide/eduide/java-17-no-ls`, `ghcr.io/eduide/eduide/rust-no-ls`, `ghcr.io/eduide/eduide/langserver-java`, `ghcr.io/eduide/eduide/langserver-rust`; added `quay.io/oauth2-proxy/oauth2-proxy:v7.12.0` with `args: ["--version"]`; updated comments to document index mapping to workflow overrides (indices 0–10 and index 11).
Helm chart values `charts/theia-cloud-combined/values.yaml`	Mirrored the same additions to chart-level `theia-cloud.preloading.images` and expanded explanatory comment about index alignment with workflow overrides.
CI workflow `.github/workflows/deploy-theia.yml`	Clarified inline comments describing how `IDE_IMAGES_TAG` string overrides map to specific `theia-cloud.preloading.images[...]` indices; explicitly noted index 11 corresponds to `oauth2-proxy` and should remain controlled by values.yaml. No control flow or command changes.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

feat: migrate AppDefinitions to v1beta11 sidecars #73 — Modifies the same preloading image lists and deploy workflow (overlapping image additions).
Add support for customizable image tags in Theia deployment workflows #22 — Introduced IDE_IMAGES_TAG-driven --set overrides; directly related to documented index alignment.
fix(ci): empty tag inputs no longer override values.yaml image settings #77 — Related changes to deploy-theia workflow and mapping of preloading image indices.

Suggested labels

ready to merge

Suggested reviewers

CodeByNikolas
Mtze

Poem

🐰 I hopped through YAML fields today,
New images tucked in neat array,
Java, Rust and servers four,
OAuth2 checks version more,
Preloads set — hop, deploy away!

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Use flexible preloading for oauth image' accurately reflects the main changes: adding oauth2-proxy with explicit configuration to preloading lists across multiple deployment values files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feat/flexible-preloading

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

Updates the Test1 Helm values to preload an additional container image (oauth2-proxy), presumably to reduce cold-start delays by ensuring the image is pulled ahead of time.

Changes:

Add an oauth2-proxy image entry to theia-cloud.preloading.images, with custom args (--version).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

deployments/test1.theia-test.artemis.cit.tum.de/values.yaml

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@deployments/test2.theia-test.artemis.cit.tum.de/values.yaml`:
- Around line 73-74: Update the pinned oauth2-proxy image tag from v7.12.0 to
the current v7.15.0 by changing the image value in the values block where
"image: quay.io/oauth2-proxy/oauth2-proxy:v7.12.0" is defined (the same block
that contains args: ["--version"]); replace the version suffix so the line reads
quay.io/oauth2-proxy/oauth2-proxy:v7.15.0.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0c65b94b-15b4-4c19-9437-96d12f4ce19a

📥 Commits

Reviewing files that changed from the base of the PR and between ad614e4 and a2bcfdc.

📒 Files selected for processing (7)

.github/workflows/deploy-theia.yml
charts/theia-cloud-combined/values.yaml
deployments/test1.theia-test.artemis.cit.tum.de/values.yaml
deployments/test2.theia-test.artemis.cit.tum.de/values.yaml
deployments/test3.theia-test.artemis.cit.tum.de/values.yaml
deployments/theia-staging.artemis.cit.tum.de/values.yaml
deployments/theia.artemis.cit.tum.de/values.yaml

✅ Files skipped from review due to trivial changes (1)

.github/workflows/deploy-theia.yml

🚧 Files skipped from review as they are similar to previous changes (1)

deployments/test1.theia-test.artemis.cit.tum.de/values.yaml

deployments/test2.theia-test.artemis.cit.tum.de/values.yaml

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

CodeByNikolas

lgtm

Use flexible preloading for oauth image

ad614e4

Copilot AI review requested due to automatic review settings March 23, 2026 12:16

lukaskratzel requested a deployment to test3 March 23, 2026 12:16 — with GitHub Actions Waiting

lukaskratzel requested a deployment to test2 March 23, 2026 12:16 — with GitHub Actions Waiting

lukaskratzel temporarily deployed to test1 March 23, 2026 12:16 — with GitHub Actions Inactive

github-actions bot assigned lukaskratzel Mar 23, 2026

Copilot started reviewing on behalf of lukaskratzel March 23, 2026 12:16 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

deployments/test1.theia-test.artemis.cit.tum.de/values.yaml Show resolved Hide resolved

lukaskratzel requested a deployment to test3 March 23, 2026 12:21 — with GitHub Actions Waiting

lukaskratzel temporarily deployed to test1 March 23, 2026 12:21 — with GitHub Actions Inactive

lukaskratzel requested a deployment to test2 March 23, 2026 12:21 — with GitHub Actions Waiting

lukaskratzel requested a deployment to test1 March 23, 2026 13:20 — with GitHub Actions Waiting

lukaskratzel requested a deployment to test3 March 23, 2026 13:20 — with GitHub Actions Waiting

lukaskratzel requested a deployment to test2 March 23, 2026 13:20 — with GitHub Actions Waiting

coderabbitai bot reviewed Mar 23, 2026

View reviewed changes

deployments/test2.theia-test.artemis.cit.tum.de/values.yaml Show resolved Hide resolved

Use flexible preloading approach to preload outh proxy image

c849426

Copilot AI review requested due to automatic review settings March 23, 2026 13:37

lukaskratzel force-pushed the feat/flexible-preloading branch from a2bcfdc to c849426 Compare March 23, 2026 13:37

lukaskratzel requested a deployment to test2 March 23, 2026 13:37 — with GitHub Actions Waiting

lukaskratzel requested a deployment to test1 March 23, 2026 13:37 — with GitHub Actions Waiting

lukaskratzel requested a deployment to test3 March 23, 2026 13:37 — with GitHub Actions Waiting

Copilot started reviewing on behalf of lukaskratzel March 23, 2026 13:37 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

CodeByNikolas approved these changes Mar 24, 2026

View reviewed changes

CodeByNikolas merged commit de56e6a into main Mar 24, 2026
7 of 10 checks passed

coderabbitai bot mentioned this pull request Mar 25, 2026

Expose deploy inputs and pin staging/prod images #87

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use flexible preloading for oauth image#85

Use flexible preloading for oauth image#85
CodeByNikolas merged 2 commits intomainfrom
feat/flexible-preloading

lukaskratzel commented Mar 23, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Mar 23, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

CodeByNikolas left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

lukaskratzel commented Mar 23, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

CodeByNikolas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lukaskratzel commented Mar 23, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 23, 2026 •

edited

Loading