Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(WIP) Implemented proper ROS service behavior and modified Auto Dig and Auto Offload logic #298
base: main
Are you sure you want to change the base?
(WIP) Implemented proper ROS service behavior and modified Auto Dig and Auto Offload logic #298
Changes from 57 commits
5c98c98
9382a9c
a976131
3ef8cc7
2f2f232
9e64914
846b2fe
0c1b0b8
d81054b
d502c20
b4c1b05
d0ea543
1cf4c28
ad4e84c
6609ef2
c027945
466a705
e984b9a
912db1a
c2a1bc4
f1e6d55
62f99ef
3a2056d
7a2fb6c
dfc0719
bd70e1b
2e93187
cb6d18e
a058008
413be1e
3656b70
1b4fb4a
8b3fa30
dfff57b
74f651c
b0d67cc
297e80e
cc8ee93
f5e5957
f7c39f7
48fe448
847ba94
c71be3b
b17b67e
6cf106c
9de17c8
fa0d28e
b52316c
3623d28
b6fd434
3741a42
82c01be
e05dd76
ed4f5e8
e95ff0f
67c4146
413388a
d1d9f34
570e9ce
114bb19
610e507
d9512aa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once again waiting in while loops like this is quite cpu intensive, try something event driven
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you do if you want to stop the motor before it reaches its final position