Skip to content

Feat/#76 prod 관련 파일들 수정 - #77

Merged
roode1017 merged 2 commits into
devfrom
feat/#76
Aug 19, 2025
Merged

Feat/#76 prod 관련 파일들 수정#77
roode1017 merged 2 commits into
devfrom
feat/#76

Conversation

@roode1017

@roode1017 roode1017 commented Aug 19, 2025

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • 신기능/개선

    • OAuth 로그인 성공 후 리다이렉트가 환경 설정값을 사용해 도메인별로 정확히 이동하도록 개선.
  • Chores

    • 배포 워크플로우에서 JDK를 17로 통일.
    • .env 파일 전송을 제외하고, 원격 서버에서 비밀값으로 .env 생성하도록 변경.
    • EC2 사용자의 Docker 권한 설정을 보완.
    • 프로덕션 구성에서 Kafka/ZooKeeper 제거로 경량화, Elasticsearch 메모리 할당 상향으로 안정성 개선.

@roode1017 roode1017 self-assigned this Aug 19, 2025
@roode1017 roode1017 added the enhancement New feature or request label Aug 19, 2025
@roode1017 roode1017 linked an issue Aug 19, 2025 that may be closed by this pull request
@coderabbitai

coderabbitai Bot commented Aug 19, 2025

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

배포 워크플로에서 JDK를 21→17로 변경하고 .env 전송을 중단, EC2에서 비밀 값으로 .env를 생성하도록 수정. Docker 그룹 사용자 지정. 백엔드 OAuth2 성공 리다이렉트 URL을 프로퍼티 기반 동적 구성으로 변경. docker-compose에서 Kafka/Zookeeper 제거, Elasticsearch 메모리 1g로 상향.

Changes

Cohort / File(s) Summary
CI/CD: Deploy Workflow
.github/workflows/deploy.yml
JDK 17 사용. 아티팩트 전송 목록에서 .env 제외. EC2 원격 스크립트에서 EC2_ENV_FILE.env 생성. usermod 대상 ec2-user로 명시. 단계 설명 업데이트(.env 제외 명시).
Auth Redirect Construction
backendProject/src/main/java/.../security/oauth/OAuth2SuccessHandler.java
@Value("${frontend.https.url}") 주입 추가. UriComponentsBuilderfrontendUrl + /auth/callback?accessToken=... 구성. 기존 토큰/쿠키 로직 불변.
Prod Properties Formatting
backendProject/src/main/resources/application-prod.properties
frontend.https.url=${FRONTEND_HTTPS_URL} 위치 이동 및 주석 제거. 값/키는 동일.
Prod Compose Services
docker-compose-prod.yml
mlb-zookeeper, mlb-kafka 서비스 제거. mlb-elasticsearch ES_JAVA_OPTS-Xms1g -Xmx1g로 변경.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User as 사용자
  participant BE as Backend (Spring)
  participant H as OAuth2SuccessHandler
  participant P as Properties

  User->>BE: OAuth2 로그인 완료 콜백
  BE->>H: onAuthenticationSuccess(authentication, request, response)
  H->>P: frontend.https.url 조회
  P-->>H: https://<frontend-host>
  H->>H: accessToken 생성 및 쿠키 처리(기존대로)
  H->>BE: redirectUrl = frontendUrl + "/auth/callback?accessToken=..."
  BE-->>User: 302 Redirect

  note over H,BE: 리다이렉트 대상이 하드코드에서 프로퍼티 기반으로 변경
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Poem

(\/)

(•
•) 토큰을 품고 깡충—

< 접속은 프론트 주소로, 길 잃지 않게 >

서버엔 비밀로 .env를 빚고,

컨테이너는 가벼이—카프카는 인사드려요!

바람은 1g 메모리로 불고,

배포 토끼는 오늘도 점프! 🐇🚀

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 1b9a042 and 0a95790.

📒 Files selected for processing (4)
  • .github/workflows/deploy.yml (3 hunks)
  • backendProject/src/main/java/likelion/mlb/backendProject/global/security/oauth/OAuth2SuccessHandler.java (3 hunks)
  • backendProject/src/main/resources/application-prod.properties (1 hunks)
  • docker-compose-prod.yml (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/#76

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@roode1017
roode1017 merged commit 9f6d20b into dev Aug 19, 2025
1 check was pending
@roode1017
roode1017 deleted the feat/#76 branch August 19, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat/ prod 관련 파일 변경

1 participant