chore: update brand color tokens for dark theme consistency #839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
📖 Storybook Preview |
7 tasks
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
georgewrmarshall
added a commit
that referenced
this pull request
Oct 22, 2025
## **Description** Adds a new Storybook example story that demonstrates the layered background token system and text/icon color variations. This story provides a visual showcase for testing and reviewing the brand color token updates implemented in PR #839. The story includes layered background examples (default → section → subsection), modal-style overlays, and comprehensive text/icon color demonstrations to validate the design token hierarchy and ensure proper color contrast relationships. ## **Related issues** Related to: #839 ## **Manual testing steps** 1. Run Storybook: `yarn storybook` 2. Navigate to **"Examples/Backgrounds"** in the sidebar 3. Review the layered background demonstrations: - **Background Default** → **Background Section** → **Background Subsection** hierarchy - **Background Alternative** with **Background Default** overlay (modal example) 4. Verify text and icon color variations: - Default text/icon colors - Alternative text/icon colors (updated to #9b9b9b) - Muted text/icon colors (updated to #48484e) 5. Compare with main branch Storybook to observe color differences 6. Test in both light and dark themes to ensure proper token application 7. Verify proper color contrast and visual hierarchy ## **Screenshots/Recordings** ### **Before** No previous version - this is a new story ### **After** <img width="1508" height="867" alt="Screenshot 2025-10-22 at 1 37 30 PM" src="https://github.com/user-attachments/assets/b067066a-9533-4725-9fb7-8fab96b4211d" /> <img width="1509" height="864" alt="Screenshot 2025-10-22 at 1 38 05 PM" src="https://github.com/user-attachments/assets/084d87ce-3d3e-40dd-8c1c-272e52ecaef3" /> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Adds Backgrounds example stories (web and React Native) demonstrating layered background tokens and text/icon color variants, and registers the RN story in Storybook config. > > - **Storybook**: > - **New examples**: Adds `Examples/Backgrounds` stories in `apps/storybook-react/stories/Backgrounds.stories.tsx` and `apps/storybook-react-native/stories/Backgrounds.stories.tsx` showcasing layered background tokens (`BackgroundDefault → BackgroundSection → BackgroundSubsection`) with text/icon color variants and button examples. > - **React Native config**: Registers the new story in `apps/storybook-react-native/.storybook/storybook.requires.js`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 5b50dee. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Contributor
📖 Storybook Preview |
Contributor
📖 Storybook Preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates brand color tokens to align with the latest Figma dark theme specifications.
Note: This PR updates brand color tokens rather than theme-specific tokens to maintain the design system's hierarchical token structure:
Dark Theme Color Updates
Token Value Changes
Token Architecture Mapping
semantic-token → brand-color → hex-value
Dark Theme:
Light Theme:
Related issues
Fixes:
Manual testing steps
yarn storybookor go to View PR Storybook and compare against View Main StorybookScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist