Skip to content

mqtt: Improve handling of multiple PDU parsing#10279

Closed
jlucovsky wants to merge 1 commit intoOISF:masterfrom
jlucovsky:6592/4
Closed

mqtt: Improve handling of multiple PDU parsing#10279
jlucovsky wants to merge 1 commit intoOISF:masterfrom
jlucovsky:6592/4

Conversation

@jlucovsky
Copy link
Contributor

Continuation of #10262

Issue: 6592

Link to redmine ticket: 6592

Describe changes:

  • Parse PDU instead of entire stream

Updates:

  • Ensure frame created with proper size

Provide values to any of the below to override the defaults.

To use a pull request use a branch name like pr/N where N is the
pull request number.

Alternatively, SV_BRANCH may also be a link to an
OISF/suricata-verify pull-request.

SV_REPO=
SV_BRANCH=pr/1609
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

@catenacyber
Copy link
Contributor

Guess SV PR needs an update, see my remarks there

@codecov
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c3b3c11) 82.28% compared to head (1e51d70) 82.31%.
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10279      +/-   ##
==========================================
+ Coverage   82.28%   82.31%   +0.03%     
==========================================
  Files         977      978       +1     
  Lines      271950   272031      +81     
==========================================
+ Hits       223784   223935     +151     
+ Misses      48166    48096      -70     
Flag Coverage Δ
fuzzcorpus 63.47% <100.00%> (+0.07%) ⬆️
suricata-verify 61.49% <0.00%> (-0.03%) ⬇️
unittests 62.84% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 17948

@jlucovsky
Copy link
Contributor Author

Continued in #10305

@jlucovsky jlucovsky closed this Feb 2, 2024
@jlucovsky jlucovsky deleted the 6592/4 branch April 24, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants