mqtt: Improve handling of multiple PDU parsing#10305
Closed
jlucovsky wants to merge 1 commit intoOISF:masterfrom
Closed
mqtt: Improve handling of multiple PDU parsing#10305jlucovsky wants to merge 1 commit intoOISF:masterfrom
jlucovsky wants to merge 1 commit intoOISF:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10305 +/- ##
===========================================
+ Coverage 73.31% 82.33% +9.02%
===========================================
Files 895 978 +83
Lines 148215 272029 +123814
===========================================
+ Hits 108666 223981 +115315
- Misses 39549 48048 +8499
Flags with carried forward coverage won't be shown. Click here to find out more. |
catenacyber
reviewed
Feb 2, 2024
Contributor
catenacyber
left a comment
There was a problem hiding this comment.
Code looks good to me.
Commit message should mention "frames" ;-)
Contributor
Author
|
Continued in #10309 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #10279
Issue: 6592
Link to redmine ticket: 6592
Describe changes:
Updates:
Provide values to any of the below to override the defaults.
To use a pull request use a branch name like
pr/NwhereNis thepull request number.
Alternatively,
SV_BRANCHmay also be a link to anOISF/suricata-verify pull-request.