Skip to content

mqtt: Improve frame parsing w/mult. PDUs#10309

Closed
jlucovsky wants to merge 1 commit intoOISF:masterfrom
jlucovsky:6592/6
Closed

mqtt: Improve frame parsing w/mult. PDUs#10309
jlucovsky wants to merge 1 commit intoOISF:masterfrom
jlucovsky:6592/6

Conversation

@jlucovsky
Copy link
Contributor

@jlucovsky jlucovsky commented Feb 4, 2024

Continuation of #10305

Issue: 6592

Link to redmine ticket: 6592

Describe changes:

  • Parse PDU instead of entire stream

Updates:

Provide values to any of the below to override the defaults.

To use a pull request use a branch name like pr/N where N is the
pull request number.

Alternatively, SV_BRANCH may also be a link to an
OISF/suricata-verify pull-request.

SV_REPO=
SV_BRANCH=pr/1609
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

This commit improves the mqtt parsing of frames to handle multiple PDUs.

Issue: 6592
@codecov
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (244a35d) 73.31% compared to head (f55627f) 82.34%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #10309       +/-   ##
===========================================
+ Coverage   73.31%   82.34%    +9.02%     
===========================================
  Files         895      978       +83     
  Lines      148215   272029   +123814     
===========================================
+ Hits       108666   224001   +115335     
- Misses      39549    48028     +8479     
Flag Coverage Δ
fuzzcorpus 63.59% <100.00%> (+0.11%) ⬆️
suricata-verify 61.50% <100.00%> (-0.03%) ⬇️
unittests 62.84% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

WARNING:

ERROR: QA failed on SURI_TLPR1_alerts_cmp.

field baseline test %
SURI_TLPW1_stats_chk
.flow.spare 999831 1100135 110.03%
SURI_TLPR1_stats_chk
.memcap_pressure 57 46 80.7%
.memcap_pressure_max 62 70 112.9%
.http.memuse 373800 437344 117.0%

Pipeline 18068

Copy link
Contributor

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@victorjulien victorjulien added this to the 8.0 milestone Feb 14, 2024
@victorjulien
Copy link
Member

Merged in #10419, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants