Skip to content

Applayer plugin 5053 v2.7#11507

Closed
catenacyber wants to merge 7 commits intoOISF:masterfrom
catenacyber:applayer-plugin-5053-v2.7
Closed

Applayer plugin 5053 v2.7#11507
catenacyber wants to merge 7 commits intoOISF:masterfrom
catenacyber:applayer-plugin-5053-v2.7

Conversation

@catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
Preliminary work for https://redmine.openinfosecfoundation.org/issues/5053

Describe changes:

  • get ready to use dynamic number of app-layer protos for some global arrays : run modes and output

Small PR that should be good in itself.

#11373 next round

Based on #11473 with cleaner history, waiting for CI

Still more work to do : I guess stack allocated arrays are fine, but the global variables cf git grep '\[ALPROTO_MAX' in

  • app-layer-detect-proto.c
  • app-layer-frames.c
  • app-layer-parser.c
  • app-layer-protos.c
  • app-layer.c
    need to be allocated and freed, with taking care of the initialization order, so that we know ALPROTO_MAX final value...

@codecov
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 6 lines in your changes missing coverage. Please review.

Project coverage is 82.67%. Comparing base (223a419) to head (b87188e).
Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11507      +/-   ##
==========================================
+ Coverage   82.56%   82.67%   +0.11%     
==========================================
  Files         938      918      -20     
  Lines      248247   247482     -765     
==========================================
- Hits       204961   204616     -345     
+ Misses      43286    42866     -420     
Flag Coverage Δ
fuzzcorpus 60.97% <68.25%> (+0.30%) ⬆️
livemode 18.75% <76.19%> (+0.06%) ⬆️
pcap 43.85% <84.12%> (+0.19%) ⬆️
suricata-verify 61.65% <85.71%> (+0.09%) ⬆️
unittests 59.31% <57.14%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

ERROR:
ERROR: ASAN TEST FAIL in ASAN_TLPR1_cfg QA test

ERROR: QA failed on ASAN_TLPR1_cfg.

Pipeline 21568

@catenacyber
Copy link
Contributor Author

Pushing a fixup commit to fix the leak in engine-analysis mode

It looks like this leak was preexisting, but not detected as long as the pointers lived in a global structure

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 21582

@suricata-qa
Copy link

ERROR:

ERROR: QA failed on SURI_TLPW1_suri_time.

Pipeline 21598

@catenacyber
Copy link
Contributor Author

Continued in #11532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants