flowbits: add deprecation notice for toggle command - #15664
Merged
Conversation
to deal with the failure due to cbindgen updates and mismatches in
generated bindings.
detect-bytemath.c:61: error: "DETECT_BYTEMATH_ENDIAN_DEFAULT" redefined [-Werror]
61 | #define DETECT_BYTEMATH_ENDIAN_DEFAULT (uint8_t) BigEndian
|
In file included from rust.h:34,
from detect-bytemath.c:32:
./../rust/gen/rust-bindings.h:5071: note: this is the location of the previous definition
5071 | #define DETECT_BYTEMATH_ENDIAN_DEFAULT BigEndian
|
Contributor
|
Looks ok for me, why a draft ? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main-7.0.x #15664 +/- ##
===========================================
Coverage 81.52% 81.52%
===========================================
Files 925 925
Lines 252965 252970 +5
===========================================
+ Hits 206235 206241 +6
+ Misses 46730 46729 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Member
Author
was waiting for CI to pass :P |
inashivb
marked this pull request as ready for review
June 18, 2026 08:58
inashivb
requested review from
jasonish,
jufajardini and
victorjulien
as code owners
June 18, 2026 08:58
jufajardini
reviewed
Jun 18, 2026
| Reverses the present setting. So for example if a condition is set, | ||
| it will be unset and vice-versa. | ||
|
|
||
| .. deprecated:: 7.0.17 |
Contributor
There was a problem hiding this comment.
TIL this annotation style. ✨
Member
Author
There was a problem hiding this comment.
AI told me about this 🙈
jufajardini
approved these changes
Jun 18, 2026
jufajardini
left a comment
jufajardini
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, as well :P
|
WARNING:
Pipeline = 32154 |
victorjulien
approved these changes
Jun 21, 2026
Member
|
Merged in #15694, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous PR: #15578
Changes since v1:
Link to ticket: https://redmine.openinfosecfoundation.org/issues/8638