Skip to content

Comments

dpdk: add support for DPDK Bond PMD v3#8953

Closed
lukashino wants to merge 8 commits intoOISF:masterfrom
lukashino:bond-ixgbe-working-v3
Closed

dpdk: add support for DPDK Bond PMD v3#8953
lukashino wants to merge 8 commits intoOISF:masterfrom
lukashino:bond-ixgbe-working-v3

Conversation

@lukashino
Copy link
Contributor

@lukashino lukashino commented Jun 2, 2023

Follow-up of #8943

Link to redmine ticket:

Describe changes:

  • PR comments - refactoring, variables declarations, debug info, coding style
  • configure.ac - added a check for DPDK Bond PMD
  • Guard functions intended for DPDK 20.11+ from lower version

Lukas Sismis added 8 commits June 2, 2023 16:56
Setting rss_conf->rss_key to NULL and rss_key_len
to zero avoids warnings about register changes
when setting up RSS configuration through RTE flows.
In DPDK 19.11 Suricata does not setup RSS on i40e driver
with rte_flow. As a result, it should not be deinitializing
RSS configuration with rte_flow as well.
Header checking (AC_CHECK_HEADER) did not work as
DPDK 19.11 included rte_eth_bond.h file even if net/bonding
driver was disabled. However, it was still not available in
ldconfig configuration. For this reason Bond PMD is checked with
ldconfig tool.
However when installing the DPDK library manually, the user needs to
update the entries in ldconfig to be able to find the Bond PMD.

Ticket: OISF#6099
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #8953 (00b1575) into master (5b160d2) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8953      +/-   ##
==========================================
- Coverage   82.39%   82.39%   -0.01%     
==========================================
  Files         969      969              
  Lines      273558   273559       +1     
==========================================
- Hits       225404   225401       -3     
- Misses      48154    48158       +4     
Flag Coverage Δ
fuzzcorpus 64.87% <ø> (+0.01%) ⬆️
suricata-verify 60.47% <ø> (-0.01%) ⬇️
unittests 62.93% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 14211

@victorjulien
Copy link
Member

Merged in #8965, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants