Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RQA-2592] fix(motion-control): motor driver error surfacing #772

Merged
merged 1 commit into from
Apr 22, 2024
Merged

[RQA-2592] fix(motion-control): motor driver error surfacing #772

merged 1 commit into from
Apr 22, 2024

Conversation

pmoegenburg
Copy link
Contributor

@pmoegenburg pmoegenburg commented Apr 22, 2024 •
edited
Loading

Fixes (motor driver false positive) error seen with 96-channel pipette. To test, successfully calibrated 96-channel pipette as well as gripper and then homed.

@pmoegenburg pmoegenburg self-assigned this Apr 22, 2024
ahiuchingau
ahiuchingau approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@ahiuchingau ahiuchingau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOICE

@pmoegenburg pmoegenburg merged commit 6599290 into main Apr 22, 2024
36 of 37 checks passed
@pmoegenburg pmoegenburg changed the title fix(motion-control): motor driver error surfacing [RQA-2592] fix(motion-control): motor driver error surfacing Apr 23, 2024
@sfoster1 sfoster1 mentioned this pull request Apr 24, 2024
Closed
ryanthecoder added a commit that referenced this pull request May 10, 2024
@ryanthecoder
Revert "attempted fix for 96-channel motor driver error false positive (
b743bb5 
#772)"

This reverts commit 6599290.
ryanthecoder added a commit that referenced this pull request May 10, 2024
@ryanthecoder
fix(motor-control): Revert motor driver chip errors (#777)
30ff770 
* Revert "attempted fix for 96-channel motor driver error false positive (#772)"

This reverts commit 6599290.

* Revert "feat(motion-control): handle motor driver errors (#716)"

This reverts commit 762d6d5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahiuchingau ahiuchingau ahiuchingau approved these changes

@sfoster1 sfoster1 Awaiting requested review from sfoster1

Assignees

@pmoegenburg pmoegenburg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmoegenburg @ahiuchingau