Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix init_qc_report_wf connections when linc-qc and abcc-qc are disabled #1314

Merged
merged 10 commits into from
Nov 4, 2024

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Nov 4, 2024

Closes #1310. Fixes init_qc_report_wf in the scenario where linc_qc and abcc_qc are disabled, and CIFTI processing is enabled.

Changes proposed in this pull request

  • Add inputnode to workflow within init_qc_report_wf when it hasn't been connected already.

@tsalo tsalo added the bug Issues noting problems and PRs fixing those problems. label Nov 4, 2024
@tsalo tsalo changed the title Try to reproduce #1310 with existing data. Fix init_qc_report_wf connections when linc-qc and abcc-qc are disabled Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.96%. Comparing base (3c7e875) to head (882ebae).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
xcp_d/workflows/bold/plotting.py 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1314      +/-   ##
==========================================
- Coverage   78.98%   78.96%   -0.03%     
==========================================
  Files          59       59              
  Lines        7381     7383       +2     
  Branches      956      957       +1     
==========================================
  Hits         5830     5830              
- Misses       1260     1261       +1     
- Partials      291      292       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo tsalo merged commit b26cfee into PennLINC:main Nov 4, 2024
22 of 24 checks passed
@tsalo tsalo deleted the reproduce-1310 branch November 4, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues noting problems and PRs fixing those problems.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module qc_report_wf has no input
1 participant