Skip to content

Fix init_qc_report_wf connections when linc-qc and abcc-qc are disabled #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tsalo merged 10 commits into from
Nov 4, 2024
Merged

Fix init_qc_report_wf connections when linc-qc and abcc-qc are disabled #1314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d569964
Try to reproduce #1310 with existing data.
tsalo Nov 4, 2024
2b4f123
Update test_cli.py
tsalo Nov 4, 2024
1a2b48a
Patch in inputnode.
tsalo Nov 4, 2024
c5caf36
Update plotting.py
tsalo Nov 4, 2024
b7620c1
Update test_cli.py
tsalo Nov 4, 2024
96046d6
Update test_cli.py
tsalo Nov 4, 2024
2569ec8
Revert final changes to test.
tsalo Nov 4, 2024
20e6219
Merge branch 'main' into reproduce-1310
tsalo Nov 4, 2024
b4de380
Update plotting.py
tsalo Nov 4, 2024
882ebae
Update VSCode settings.
tsalo Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,8 @@
"editor.rulers": [99]
},
"python.analysis.typeCheckingMode": "off",
"ruff.configuration": "pyproject.toml",
"ruff.lineLength": 99,
"editor.defaultFormatter": "charliermarsh.ruff",
"flake8.enabled": false,
}
6 changes: 6 additions & 0 deletions xcp_d/workflows/bold/plotting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,6 +439,12 @@ def init_qc_report_wf(
(make_qc_plots_es, ds_report_postproc_qc_es, [('after_process', 'in_file')]),
]) # fmt:skip

if config.workflow.file_format != 'nifti' and not (
config.workflow.linc_qc or config.workflow.abcc_qc
):
# Need to explicitly add the inputnode to the workflow, since it's not set otherwise.
workflow.add_nodes([inputnode])

return workflow


Expand Down